Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary unboxing at JsonPrimitive.getAsBoolean() #2277

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Unnecessary unboxing at JsonPrimitive.getAsBoolean() #2277

merged 2 commits into from
Dec 13, 2022

Conversation

MaicolAntali
Copy link
Contributor

The value is cast to a Boolean. The .booleanValue() is unnecessary.

@eamonnmcmanus
Copy link
Member

It seems you're doing a number of different small cleanups to the code base, and thanks for that! I wonder if you could consolidate some of them into bigger PRs, though?

@MaicolAntali
Copy link
Contributor Author

@eamonnmcmanus yes make sense! 😄

If for you it's ok merge this one PR. The next PRs I’ll make them bigger and more consolidate

@eamonnmcmanus eamonnmcmanus merged commit 6c3cf22 into google:master Dec 13, 2022
@MaicolAntali MaicolAntali deleted the unnecessary-unboxing branch December 16, 2022 15:26
tibor-universe pushed a commit to getuniverse/gson that referenced this pull request Jan 20, 2023
@MaicolAntali @tibor-universe
Unnecessary unboxing at JsonPrimitive.getAsBoolean() (google#2277)
fad3c41 
(cherry picked from commit 6c3cf22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaicolAntali @eamonnmcmanus